Hello Thomas, Thomas Martitz <ku...@rockbox.org> writes:
> Am 16.01.2017 um 13:56 schrieb Thomas Martitz:Hello Jim and other folks, >> >> This is a friendly reminder. I've added a test suite to the >> patch. Please review. >> >> Thank you and best regards, >> Thomas Martitz >> > > this is one more friendly reminder. Please review my patch set. As the newly appointed Automake maintainer, I take up the task of reviewing your patch. Currently the Automake manual recommends against using '_SHORTNAME' unless required for portability, see: ‘maude_SHORTNAME’ On some platforms the allowable file names are very short. In order to support these systems and per-target compilation flags at the same time, Automake allows you to set a “short name” that will influence how intermediate object files are named. [...] This facility is rarely needed in practice, and we recommend avoiding it until you find it is required. As a consequence, I am a bit reluctant to add this new 'object-shortname' option which seems like a convenience for something not recommended. Having said that, not being able to use '_SHORTNAME' with %reldir% and %canon_reldir% inside Makefile snippets seems like a bug. What about trying to fix it without the 'object-shortname' option? I hope my feedback after such long review delay will not be too frustrating. :/ Thank you. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37