Hi,
Please revert the CONFIG_COMMANDS part of
2001-02-04 Kevin Ryde <[EMAIL PROTECTED]>
* automake.in (handle_configure): Call config.status with empty
CONFIG_LINKS and CONFIG_COMMANDS when regenerating a file.
This doesn't work with beta autoconf 2.49d and
AC_OUTPUT(outputs, commands)
syntax. For example, 'automake's configure.in uses
AC_OUTPUT([Makefile automake aclocal m4/Makefile tests/Makefile],
[chmod +x automake aclocal])
However,
automake: $(top_builddir)/config.status automake.in
cd $(top_builddir) && \
CONFIG_FILES=$@ CONFIG_HEADERS= CONFIG_LINKS= CONFIG_COMMANDS= \
$(SHELL) ./config.status
doesn't run the 'chmod +x automake'. This is because the old
AC_OUTPUT syntax appears to be internally implemented via
CONFIG_COMMANDS, and the explicit setting interferes with that.
This only affects beta autoconf, and CONFIG_COMMANDS was introduced
only with beta autoconf. So, it is safe to revert this part.
I don't think similar changes should be incorporated in the future.
It would be better to migrate to the new config.status command line
interface if AC_PREREQ(2.50) is seen,
./config.status --files=$@
rather than depend on specific details of the implementation of
config.status.
I've attached a patch only to revert the CONFIG_COMMANDS case. I
think the CONFIG_LINKS= part in the above is harmless.
- Hari
from Raja R Harinath <[EMAIL PROTECTED]>
* automake.in (handle_configure): Revert part of
'2001-02-04 Kevin Ryde <[EMAIL PROTECTED]>'. Don't
set CONFIG_COMMANDS explicitly.
Index: automake.in
===================================================================
RCS file: /cvs/automake/automake/automake.in,v
retrieving revision 1.871
diff -u -p -u -r1.871 automake.in
--- automake.in 2001/02/09 03:39:18 1.871
+++ automake.in 2001/02/09 18:52:50
@@ -3185,7 +3185,7 @@ sub handle_configure
. "\t && CONFIG_FILES="
. (($relative_dir eq '.') ? '$@' : '$(subdir)/$@')
. $colon_infile
- . ' CONFIG_HEADERS= CONFIG_LINKS= CONFIG_COMMANDS= $(SHELL) ./config.status'
+ . ' CONFIG_HEADERS= CONFIG_LINKS= $(SHELL) ./config.status'
. "\n\n");
if ($relative_dir ne '.')
@@ -3437,7 +3437,7 @@ sub handle_configure
. '$@' . ($need_rewritten
? (':' . join (':', @inputs))
: '')
- . ' CONFIG_HEADERS= CONFIG_LINKS= CONFIG_COMMANDS= $(SHELL) ./config.status'
+ . ' CONFIG_HEADERS= CONFIG_LINKS= $(SHELL) ./config.status'
. "\n");
push (@actual_other_files, $local);
--
Raja R Harinath ------------------------------ [EMAIL PROTECTED]
"When all else fails, read the instructions." -- Cahn's Axiom
"Our policy is, when in doubt, do the right thing." -- Roy L Ash
