Ralf Wildenhues wrote: > Could you make a tarball exposing the bug you see available? http://www.zarb.org/~guillomovitch/rpmbuildupdate-0.7.tar.gz
> Some minor nits: > >> rpmbuildupdate: $(srcdir)/rpmbuildupdate.in >> perl -pi -e s'|[EMAIL PROTECTED]@|$(sysconfdir)|' < $< > $@ >> >> rpmbuildupdate.comp: $(srcdir)/rpmbuildupdate.comp.in >> perl -pi -e s'|[EMAIL PROTECTED]@|$(sysconfdir)|' < $< > $@ > > BSD make does not support '$<' except in inference rules. If you > care about portability to MinGW, you should use a backup suffix > for perl (e.g., "-pi~"), as files can't be replaced in-place there. > If you list rpmbuildupdate.in and rpmbuildupdate.comp.in as > prerequisites including the "$(srcdir)/", then you need to do so > everywhere you mention it, otherwise some make implementations > won't know "file" and "./file" are the same; OTOH if you omit the > "$(srcdir)/" in the prerequisite list, then you should know that > Solaris make will rewrite your rule to add the $(srcdir)/ auto- > matically in a VPATH build, while other make implementations > won't. (Usual rule is to not support VPATH setups with Solaris > make, or to add the $(srcdir)/ in every place, also in EXTRA_DIST.) > > All this and more in > http://www.gnu.org/software/autoconf/manual/html_node/Portable-Make.html > >> install-data-hook: >> mv $(DESTDIR)/$(completiondir)/rpmbuildupdate.comp \ >> $(DESTDIR)/$(completiondir)/rpmbuildupdate > > You should not put a '/' after $(DESTDIR): For example, if you care > about portability to w32 systems such as MinGW, people there like to > do > ./configure --prefix=C:/some/path > > (they typically don't mind if DESTDIR support does not work in that > case). In that particular case, I'm not sure a rpm-handling software is really useful elsewhere as Linux, but anyway this is good to know. Thanks for the tips. -- Guillaume Rousse Projet Estime, INRIA Domaine de Voluceau Rocquencourt - B.P. 105 78153 Le Chesnay Cedex - France
