-- With Valediction, Kamila Szewczyk (https://iczelia.net)
On 9/22/26 9:13 PM, Zack Weinberg wrote:
On Wed, Sep 16, 2026, at 1:52 PM, Kamila Szewczyk wrote:- Inform the autoconf upstream ([email protected]) that autoreconf should run libtoolize --ltdl before recursing into subdirectories, since libtoolize is what fills them.Does this change look right to you? I know autopoint may also populate subdirectories, and it wouldn't surprise me at all if gtkdocize and intltoolize did (but I know next to nothing about them). This needs tests; are any of you up to writing one? I don't know when I will have time. Also, is anyone up to doing a distribution archive rebuild with this patch applied? Changes to order of operations in autorepoint have a relatively high risk of breaking something. zw diff --git i/bin/autoreconf.in w/bin/autoreconf.in index 65570cf8..65bf9eae 100644 --- i/bin/autoreconf.in +++ w/bin/autoreconf.in @@ -809,20 +809,6 @@ sub autoreconf_current_directory ($) } $traces->close;- # The subdirs are *optional*, they may not exist.- foreach (@subdir) - { - if (-d) - { - verb "$configure_ac: adding subdirectory $_ to autoreconf"; - autoreconf ($_); - } - else - { - verb "$configure_ac: subdirectory $_ not present"; - } - } - # Gettext consistency checks. # Some projects intentionally don't call AM_GNU_GETTEXT_(REQUIRE_)VERSION # because they have all of the gettext infrastructure checked into version @@ -969,6 +955,28 @@ sub autoreconf_current_directory ($) $rerun_aclocal = 1 if $invoked_autopoint && !@macro_dirs;+ # --------------------------- #+ # Processing subdirectories. # + # --------------------------- # + + # The subdirs are *optional*, they may not exist. This needs to + # happen after everything that might populate a subdirectory + # (autopoint and libtoolize in particular may do this) but before + # the second run of aclocal at this level. + foreach (@subdir) + { + if (-d) + { + verb "$configure_ac: adding subdirectory $_ to autoreconf"; + autoreconf ($_); + } + else + { + verb "$configure_ac: subdirectory $_ not present"; + } + } + + # ------------------- # # Rerunning aclocal. # # ------------------- #
OpenPGP_0xC868F0B6DE38409D.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Description: OpenPGP digital signature
