On 09/06/2012 02:39 AM, Qingtang Zhou wrote:
* On 2012-09-05 01:57:00 -0300, Lucas Meneghel Rodrigues ([email protected])
wrote:
Hi guys, I'm in the verge of committing the consolidation of all
current virt tests into client/tests/virt. I ask you guys to review
https://github.com/autotest/autotest/pull/533
And also test the result. To test under autotest
# cd /path/to/autotest/client/tests/virt
# kvm/get_started.py
...
# ../../autotest-local kvm/control --verbose
# libvirt/get_started.py
...
# ../../autotest-local libvirt/control --verbose
There's the new test runner, which is straightforward to run. The
output is fairly minimal and colored (PASS shows as green, FAIL as
red). The only argument you pass to it currently is 'kvm' or
'libvirt'.
Please help me to review this, as I'd like to get it in the repo
this week, and get over with the test split by early next week tops.
# export AUTOTEST_PATH="/path/to/autotest"; ./run kvm
Hi Lucas,
This new tool is really nice. it's very fast, and log output is clear.
When I ran job with it, I find 2 small problem,
1) if the config file has some problem, it won't report any error,
just return directly, I have to set the 'debug' variant to True
in that 'run' script manually.
Maybe I can print the number of tests that will be run by the tool, and
show an error in case 0 tests were reported.
2) I can't stop a running job by pressing 'Ctrl+C' key, seems some
code catch this signal and ingore it. I'm reading the
standalone_test script, try to find which line cause this problem.
Yeah, my mistake, I was disabling stdin altogether, fixed in the latest
commits to the branch.
Anyway, it's a lovely tool, thank you Lucas for bring us these awesome
tools in autotest.
BTW, some case in autotest would damage guest image, seems it's one of
the qemu_img cases, all case after it was failed.
We have a backup mechanism that is disabled by default to avoid
subsequent tests from failing. Maybe it could be enabled by default..
BTW2, I guess we may need some filter for kvm test and libvirt case,
eg, if I want to test all kvm tests, I can easily set some parameters
like:
"only kvm_test"
to mark all kvm tests would be run.
Ok, good point...
Thanks for the feedback!
_______________________________________________
Autotest-kernel mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/autotest-kernel
