On Tue, Dec 22, 2009 at 1:24 PM, Martin Bligh <[email protected]> wrote:
> +cc: eric, John > > > > On Tue, Dec 22, 2009 at 10:59 AM, Martin Bligh <[email protected]> wrote: > > Do you recall why we did this? Something to do with > > creating files that couldn't be read back again, or > > overwritten? > > Answer from Eric: > > When the test logs were scped out, the permission > bit was reset to --r--r--r, which caused the second scp (overwrite) to > fail. > > John, any objections to this patch? Seems OK to me, but I know you were > altering a similar issue very recently, so wanted to check with you. > My recent change was to remove the code in send_file that would o+rx the files it copied over to the remote machine, basically because it was impossible for it to be done correctly and doing it incorrectly was causing problems. This patch could potentially interact badly with it, if it leads to files being copied over to remote machines with unusable permissions; but that seems unlikely unless the umask on the remote machine is very strange (which probably would've already been broken by my change). -- John
_______________________________________________ Autotest mailing list [email protected] http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
