On 07/01/2010 07:05 PM, Lucas Meneghel Rodrigues wrote:
> On Thu, 2010-07-01 at 17:42 +0300, Avi Kivity wrote:
>> On 06/30/2010 06:39 PM, Lucas Meneghel Rodrigues wrote:
>>> By default, HPET is enabled on qemu and no time drift
>>> mitigation is being made for it. So, add -no-hpet
>>> if qemu supports it, during windows timedrift tests.
>>>
>>>
>>
>> Hm, you're compensating for a qemu bug by not testing it.
>>
>> Can we have an XFAIL for this test instead?
>
> Certainly we can. In actuality, that's what's being done on our internal
> autotest server - this particular test is linked to the upstream bug
> https://bugs.launchpad.net/qemu/+bug/599958
>
> We've discussed about this issue this morning, it boils down to the way
> people are more comfortable with handling this issue. My first thought
> was to disable HPET until someone come up with a time drift mitigation
> strategy for it.
>
> But your approach makes more sense, unless someone has something else to
> say about it, I'll drop the patch from autotest shortly.

Actually we should do both - XFAIL when hpet is used and in addition 
(and even more importantly) test other clock sources by disabling hpet.

>
> Lucas
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to [email protected]
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

_______________________________________________
Autotest mailing list
[email protected]
http://test.kernel.org/cgi-bin/mailman/listinfo/autotest

Reply via email to