On Thu, 2010-09-23 at 17:07 +0200, Lukáš Doktor wrote:
> Hi,
> 
> for the virtio_console test ('client/tests/kvm/tests/virtio_console.py') 
> we have created a mechanism for gathering the total and processes load 
> informations. We think it might be an income for other tests too.
> 
> Should we improve it and insert it into the 
> 'client/tests/kvm/kvm_test_utils.py' or for the whole autotest 
> 'client/common_lib/utils.py'?

This is useful for several tests, so we should put it under the
utilities library for the entire autotest.

> Do you have any special requirements?

I don't think so, at least as far as I can see.

> 
> Example of usage (future version):
> ...
> loads = System_load([16203, vm1.pid, 0])
> ...
> loads.start()
> #DO YOUR STUFF
> loads.stop()
> ...
> header, rows = loads.get_status()
> logging.info(matrig_to_string(rows, header))
> ...
> 
> OUTPUT:
> NAME                  PID     USER    SYS     SUM     TIME
> vim                   16203   0%      0%      0%      120.103s
> /usr/bin/qemu-kvm     5986    87%     18%     105%    120.103s
> TOTAL                 ---     95%     37%     142%    120.103s
> 
> 
> We think that major and minor page faults and soft/hard IRQ counts might 
> be also beneficial. Feel free to make your wishes before we start 
> rewriting it.

Will think about it. By the way, I have commited some minutes ago the
latest version of the virtio_console test. I have cobbled together the
original patch, the later fix, and I also fixed some bugs in the test
while I was at it (most of them stem from the fact that there were some
duplicated functions in one of the sender classes, that was left there
by mistake). I think the test upstream is in good shape, so please use
it when you plan on writing more tests, OK?

Thank you very much for the awesome work put on this test!

Lucas

_______________________________________________
Autotest mailing list
[email protected]
http://test.kernel.org/cgi-bin/mailman/listinfo/autotest

Reply via email to