On Mon, Mar 14, 2011 at 7:19 PM, Lucas Meneghel Rodrigues <[email protected]>wrote:
> On Fri, 2011-03-11 at 04:47 -0500, Jan Stancek wrote: > > The following 2 patches add new optional parameter 'timeout' to > run_test(). > > This serves as a client-side watchdog, and test which won't complete > within > > specified timeframe is killed. > > > > Second patch is to allow passing this information to harness, which can > > setup its own (external) watchdog to deal with situations when > client-side > > watchdog isn't enough, for example: reboot the machine if it hangs. > > Looks good to me. John, would you please take a look at this patchset? > The Beaker project guys have developed this to make the client to play > nice with their infrastructure. I don't see it as a very disruptive > change, the unittests were modified accordingly and new unittests were > added. > > It seems fine to me. I'm not a big fan of backwards-incompatible changes to some of the more abstract interfaces like the harnesses, but I have doubts that the alternative (adding a new method instead of a new parameter to an existing method) is any better. I'm also a little concerned to see yet another implementation of a "timeout", autotest seems to have a few of those now. I don't see how to reuse any more of the code than this patch already does though so not having a better alternative I still think it's reasonable. -- John > > > > Jan Stancek (2): > > timeout parameter for job.run_test() > > pass run_test() timeout parameter to harness > > > > client/bin/harness.py | 3 +- > > client/bin/harness_ABAT.py | 3 +- > > client/bin/job.py | 33 ++++++++++++++++++++++------- > > client/bin/job_unittest.py | 46 > +++++++++++++++++++++++++++++++++++++--- > > client/bin/parallel.py | 29 +++++++++++++++++++++++++- > > client/common_lib/base_job.py | 2 + > > 6 files changed, 101 insertions(+), 15 deletions(-) > > _______________________________________________ > > Autotest mailing list > > [email protected] > > http://test.kernel.org/cgi-bin/mailman/listinfo/autotest > > >
_______________________________________________ Autotest mailing list [email protected] http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
