Fair enough Scott, applied your patch: http://autotest.kernel.org/changeset/5316
Thanks! On Tue, Apr 12, 2011 at 2:26 PM, Scott James Remnant <[email protected]> wrote: > On Thu, Apr 7, 2011 at 5:36 PM, <[email protected]> wrote: >> >> Small comment made on your patch set. >> >> >> >> http://codereview.chromium.org/6816032/diff/3001/client/profilers/perf/perf.py >> File client/profilers/perf/perf.py (right): >> >> >> http://codereview.chromium.org/6816032/diff/3001/client/profilers/perf/perf.py#newcode18 >> client/profilers/perf/perf.py:18: self.events = [events] >> If we are going to support the old way of passing events, one would pass >> a string such as: >> >> "cycles,instructions" >> >> So in case it is a string, better split it using commas as a separator. >> I am assuming the idea here is to support the old interface, right? >> >> http://codereview.chromium.org/6816032/ > > Well, the old way just passed the entire string, commas and all, to perf. So > I was aiming for direct compatibility > There may be some subtle differences between how perf parses that string and > the result of events.split(",") > Scott -- Lucas _______________________________________________ Autotest mailing list [email protected] http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
