On 03/22/2012 12:34 AM, Alex Jia wrote: Ping. > At present, I tend to agree your suggestion if we haven't a better > solution, maybe, Chirs can give a good advice again :-) > > Regards, > Alex > > > ----- Original Message ----- > From: "Lucas Meneghel Rodrigues"<[email protected]> > To: "Alex Jia"<[email protected]> > Cc: [email protected], [email protected], [email protected], "Chris > Evich"<[email protected]> > Sent: Thursday, March 22, 2012 12:15:51 AM > Subject: Re: [libvirt-autotest] New requirement > > On 03/21/2012 01:11 PM, Alex Jia wrote: >> We indeed should keep the module naming consistent, but I think it has >> 2 layers meaning, the one is module naming should be consistent; the >> other is related module should depict similar function, for example, >> >> kvm_monitor.py: Interfaces to the QEMU monitor >> kvm_vm.py: Utility classes and functions to handle Virtual Machine creation >> using qemu. >> >> For libvirt-autotest: >> libvirt_monitor.py: (we haven't any definition in here) >> libvirt_vm.py: Utility classes and functions to handle Virtual Machine >> creation using libvirt. >> >> For libvirt, you know it hasn't a monitor concept like qemu, virsh has only >> a qemu-monitor-command >> command to directly send qemu command to guest bypass libvirt, if we put >> all of virsh commands into libvirt_monitor module, I don't know how to >> define the module function. >> >> In addition, libvirt has also some host related virsh commands such as >> 'interface' group >> command, libvirt uses netcf library to directly mananger host network >> interface, >> it's unrelated with guest. >> >> Lucus and Chris, thanks for your suggests. > I guess the best thing here is to remove libvirt_monitor.py altogether > and introduce a virsh.py file, and call it a day. I haven't seen other feedback by now, if it's a final solution, I will commit patches to change these or others want to do it, also okay for me:
1. remove libvirt_monitor.py 2. introduce a virsh.py then move all of virsh wrapper into it 3. also need to change previous cases to follow these modification Please let me know early if you have a better suggestion. Regards, Alex > _______________________________________________ > Autotest mailing list > [email protected] > http://test.kernel.org/cgi-bin/mailman/listinfo/autotest _______________________________________________ Autotest mailing list [email protected] http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
