On 22.03.2012 [02:28:17 -0300], Lucas Meneghel Rodrigues wrote: > On Thu, Mar 8, 2012 at 8:36 PM, Nishanth Aravamudan > <[email protected]> wrote: > > Hi, > > > > So one gap in the current implementation of the install server > > functionality I noticed is that the end-user still has to fiddle with > > the backend cobbler server when they want to install a different than > > the currently selected profile. It seems like the end user should be > > able to select the profile to use on a host-by-host basis. > > > > Some implementation notes: > > > > - The link between autotest and cobbler is established by the label of > > the autotest host being found in the comment field for the profile in > > cobbler. > > I gave a look at the patchset, and I do like the fact that you > minimized intrusion in the current code. I need to go over it again. > What I have done is, pick up all the patches you've sent (including > the couple of corrections you've sent later), and made a pull request, > so I could review the patches and apply static code analysis in it > more easily: > > https://github.com/autotest/autotest/pull/240 > > So you're welcome to open your own pull request, that I could then use > as a base for reviewing and do all the back and forth necessary to get > this feature upstream. I consider it a good proof of concept, and I'd > like to work with you to get this upstream. Thank you! > > > - Many spots still need to be parameterized on the presence of the > > xmlrpc URL in the global config > > I've noticed we could factor that code out to a library function. > Also, we could have a similar function to verify whether the install > server is up and running.
I've sent an updated pull request: https://github.com/autotest/autotest/pull/254 Quite a few changes in there, including the Do_not_install profile we discussed on IRC, the library function you mentioned above, and bug fixes. Thanks, Nish -- Nishanth Aravamudan <[email protected]> IBM Linux Technology Center _______________________________________________ Autotest mailing list [email protected] http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
