On 05/10/2012 02:11 AM, tangchen wrote:
> Hi~
>
> I'm sorry for such a long delay on these patches.
>
> All the comments before have been followed, and some bugs have been fixed.
> Please comment, thanks. :)
>
>
> Tang Chen (3):
> Add {at|de}tach-interface API for libvirt_vm.
> Add 27 tests for virsh_migrate.
> Improve virsh_migrate test.
>
> client/tests/libvirt/tests/virsh_migrate.py | 292
> +++++++++++++++++++++++----
> client/virt/libvirt_vm.py | 79 +++++++
> client/virt/subtests.cfg.sample | 154 ++++++++++++--
> 3 files changed, 462 insertions(+), 63 deletions(-)
>
tangchen,
Thanks a TON for all these great tests, overall it's very thorough and
extensive. I'd really like to see some of these tests in action, but
didn't want to spend lots of time setting it up w/o providing some
initial feedback:
There are a handful of whitespace errors:
client/tests/libvirt/tests/virsh_migrate.py line 45
client/tests/libvirt/tests/virsh_migrate.py line 263
client/virt/subtests.cfg.sample line 586
client/virt/subtests.cfg.sample around line 592
do_error_migration()
This is a good catch, we need to do negative testing like this.
However, implementing it inside a test makes me a little uncomfortable.
It may be that other test modules would like to do migration error
testing but aren't able to because the code is locked up in this test.
Your comment says the migration functions are hiding some error
conditions, which reads to me like a deficiency in the core code. Could
we fix vm.migrate() and/or virsh_migrate() to support error testing?
Maybe a keyword parameter with a default could be added to one or both
to support it?
do_migration()
Thanks for changing "dly" to "delay", it's much clearer.
#FIXME: vm.verify_kernel_crash()
I'm pretty sure we fixed this by now, but I neglected to update this
test. I'll confirm by simple test (messing up root= parameter in grub).
# For safety reasons, we'd better back up xmlfile.
This is a fantastic idea! What do you think about adding this as a
method of the vm class, so we can use it elsewhere also?
If any of the above fixes/changes you don't have time/resources for,
just let me know and I'll take care of 'em. Overall it looks really
good and I'll be happy to see this applied.
I'll start working up a pair of lab boxes to run this code on.
Depending on how many "challenges" I run into doing that, it could be
late next week before I get to run any of these cool new tests. But
I'll work on it and let you know if I have more feedback.
Thanks again!
--
Chris Evich, RHCA, RHCE, RHCDS, RHCSS
Quality Assurance Engineer
e-mail: cevich + `@' + redhat.com o: 1-888-RED-HAT1 x44214
_______________________________________________
Autotest mailing list
[email protected]
http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
