I removed /usr/local/autotest to make sure I had only the latest bits. I did the install and have:
commit 716554702f8bbc86738b96272df0d27ce8be889c Author: Nishanth Aravamudan <[email protected]> Date: Thu May 17 09:21:22 2012 +0000 I ran the system install test and it now works. ray spear -----Original Message----- From: Lucas Meneghel Rodrigues [mailto:[email protected]] Sent: Friday, May 18, 2012 2:03 PM To: Spear, Raymond (Mission Critical Linux) Cc: [email protected]; cleber; Nishanth Aravamudan Subject: Re: [Autotest] [PATCH] install_server: fix repair On Fri, 2012-05-18 at 17:50 -0300, Lucas Meneghel Rodrigues wrote: > On Fri, 2012-05-18 at 18:46 +0000, Spear, Raymond (Mission Critical > Linux) wrote: > > I do not know if this is related or not. I am running autotest with this > > commit as the "head" > > > > commit 58ede1aed30d6545fb2b2be14f38b8dbdf4b33dc > > Author: Lucas Meneghel Rodrigues <[email protected]> > > Date: Thu May 17 21:35:43 2012 -0300 > > > > > > When I do the server install "test" I get the following in the debug log: > > > > 05/18 15:27:34 INFO |server_job:0117| START reinstall reinstall > > timestamp=1337380054 localtime=May 18 15:27:34 > > 05/18 15:27:34 INFO |server_job:0117| START ---- install > > timestamp=1337380054 localtime=May 18 15:27:34 tcd380-08.cce.hp.com > > 05/18 15:27:34 INFO |server_job:0117| GOOD ---- > > install.start timestamp=1337380054 localtime=May 18 15:27:34 > > tcd380-08.cce.hp.com > > 05/18 15:27:34 INFO |install_se:0115| Installing machine > > tcd380-08.cce.hp.com with profile None (timeout 3600 s) > > 05/18 15:35:52 DEBUG|install_se:0140| Cobbler got signaled that host > > tcd380-08.cce.hp.com installation is finished > > 05/18 15:35:52 INFO |install_se:0152| Host tcd380-08.cce.hp.com > > installation resulted in different profile > > 05/18 15:38:09 DEBUG|install_se:0140| Cobbler got signaled that host > > tcd380-08.cce.hp.com installation is finished > > 05/18 15:38:09 INFO |install_se:0152| Host tcd380-08.cce.hp.com > > installation resulted in different profile > > > > and the "test" then fails even though the SUT successfully installed > > (unfortunately twice). > > Like Nisanth said, the failure is expected (the code expects profile > None, but when it's going to check, it's not None). > > > Why is my profile "None". > > Well, it's worth checking if tcd380-08.cce.hp.com exists in cobbler > and does have a profile set. > > I've followed the path of the functions going through the code, and it > seems that in the case the profile is None (precisely the case of the > reinstall test), the profile never ever gets set to a string. With the > recent patch that cleber made, we do verify whether at the end of the > install the profile is what 'we want', therefore, we check > > # Check if the installed profile matches what we asked for > installed_profile = self.server.get_system(system).get('profile') > install_successful = (installed_profile == profile) > > With profile=None, install_successful can never be True. > > So, what happens is that this extra verification step did not take > into account no profile at all would be provided. > > I'll think of a fix and will send ASAP. Ok Nisanth, your patch was applied on the next branch already, and I followed the code path for the reinstall test again with your patch applied. Turns out your patch is a fix for the problem Ray is mentioning, since here: system, system_handle = self.get_system_handle(host) if profile is None: profile = self.server.get_system(system).get('profile') profile now is getting set to a valid profile in case it was None previously. That said, I've already tested this patch (we have an internal server that runs next, so I can verify if everything is good), so we're good to go. Ok, master was updated with the contents of next. Ray, please pull, and your problem should be fixed. If it's not, let us know. Cheers, Lucas _______________________________________________ Autotest mailing list [email protected] http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
