On 22.06.2012 [02:26:39 -0300], Lucas Meneghel Rodrigues wrote:
> On Thu, Jun 21, 2012 at 10:04 PM, Nishanth Aravamudan
> <[email protected]> wrote:
> > On 19.06.2012 [23:55:25 -0300], Lucas Meneghel Rodrigues wrote:
> >> Hi Nishanth,
> >>
> >> I've noticed in our internal test server that the cobbler integration
> >> patches will require some changes on the rpc client CLI module, I'm
> >> currently getting an error while trying to schedule jobs with it:
> >>
> >> Operation create_job failed:
> >> TypeError: enqueue_job() got an unexpected keyword argument 'profile'
> >>
> >> I've dropped the patches from next until we can figure this out and fix
> >> it. Meanwhile, I'll re-publish the patches so we don't lose them.
> >
> > What kind of job was being scheduled? By label, by host, etc? I see some
> > places where enqueue_job isn't taking the same parameters in all cases,
> > but I'm not sure which call path is failing...
>
> By label. I need to spend more time to trace which code path is
> failing.
Ok, I think this corresponds to the following, which is what I was
starting to suspect:
diff --git a/frontend/afe/models.py b/frontend/afe/models.py
index 9846087..791f16c 100644
--- a/frontend/afe/models.py
+++ b/frontend/afe/models.py
@@ -104,7 +104,7 @@ class Label(model_logic.ModelWithInvalid, dbmodels.Model):
self.test_set.clear()
- def enqueue_job(self, job, atomic_group=None, is_template=False):
+ def enqueue_job(self, job, profile, atomic_group=None, is_template=False):
"""Enqueue a job on any host of this label."""
queue_entry = HostQueueEntry.create(meta_host=self, job=job,
is_template=is_template,
I think this relates to what Cleber and I discussed in one of the pull
requests that it would be nice to do a web submission by label and
specify a profile still -- that is I want any ppc64 platform box, but
want fc17 on it.
The way the by-label request should work with the above, I think, is
that the profile argument will just get ignored and we should end up
running on the default OS.
-Nish
--
Nishanth Aravamudan <[email protected]>
IBM Linux Technology Center
_______________________________________________
Autotest mailing list
[email protected]
http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
