On 06/26/2012 11:31 PM, guyanhua wrote: > > Gu Yanhua (3): > Add virsh_freecell function in libvirt_vm.py. > Add virsh_freecell.py to test virsh_freecell command. > Add configuration for "virsh freecell". > > client/tests/libvirt/tests/virsh_freecell.py | 57 > ++++++++++++++++++++++++++ > client/virt/libvirt_vm.py | 7 +++ > client/virt/subtests.cfg.sample | 26 ++++++++++++ > 3 files changed, 90 insertions(+), 0 deletions(-) > create mode 100644 client/tests/libvirt/tests/virsh_freecell.py > > _______________________________________________ > Autotest mailing list > [email protected] > http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
Hey, Thanks for the tests. I put some comments in individual patches below. I only had some minor feedback/concerns, you can fix if you think they're important, overall it looks good. I'll run it through pylint and reindent quick to be sure, then push into 'next' branch. -- Chris Evich, RHCA, RHCE, RHCDS, RHCSS Quality Assurance Engineer e-mail: cevich + `@' + redhat.com o: 1-888-RED-HAT1 x44214 _______________________________________________ Autotest mailing list [email protected] http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
