One small correction: I applied this to both master and next as
recommended by lmr. Thanks again for the fix!
On 07/26/2012 11:11 AM, Chris Evich wrote:
>
> No problem, no need for sorry, we all make mistake. I'll track it down
> and apply your patch below. Thanks for reporting this bug!
>
> On 07/11/2012 04:16 AM, tangchen wrote:
>> Hi~
>>
>> It was my mistake to bring in this bug, sorry about that.
>> We should not give a default value when calling
>> virsh_{at|de}tach_interface.
>> Since Chris has apply my patch to next branch, I made this patch to
>> fix them.
>> I can rebuild the whole patch if needed. :)
>>
>> Signed-off-by: Tang Chen<[email protected]>
>> ---
>> client/virt/libvirt_vm.py | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/client/virt/libvirt_vm.py b/client/virt/libvirt_vm.py
>> index 0156338..e128fe8 100644
>> --- a/client/virt/libvirt_vm.py
>> +++ b/client/virt/libvirt_vm.py
>> @@ -1359,7 +1359,7 @@ class VM(virt_vm.BaseVM):
>> Attach a NIC to VM.
>> """
>> return virsh_attach_interface(self.name, option,
>> self.connect_uri,
>> - ignore_status=False,
>> print_info=False)
>> + ignore_status=ignore_status,
>> print_info=print_info)
>>
>>
>> def detach_interface(self, option="", ignore_status=False,
>> print_info=False):
>> @@ -1367,7 +1367,7 @@ class VM(virt_vm.BaseVM):
>> Detach a NIC to VM.
>> """
>> return virsh_detach_interface(self.name, option,
>> self.connect_uri,
>> - ignore_status=False,
>> print_info=False)
>> + ignore_status=ignore_status,
>> print_info=print_info)
>>
>>
>> def destroy(self, gracefully=True, free_mac_addresses=True):
>
>
> --
> Chris Evich, RHCA, RHCE, RHCDS, RHCSS
> Quality Assurance Engineer
> e-mail: cevich + `@' + redhat.com o: 1-888-RED-HAT1 x44214
--
Chris Evich, RHCA, RHCE, RHCDS, RHCSS
Quality Assurance Engineer
e-mail: cevich + `@' + redhat.com o: 1-888-RED-HAT1 x44214
_______________________________________________
Autotest mailing list
[email protected]
http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
