Peter Donald a �crit :
>
> On Thu, 26 Jul 2001 00:43, Sylvain Wallez wrote:
> > Since there seems to be interest for it, the files are attached and I'd
> > be happy to see the non-Cocoon specific part of them included in a
> > future LogKit release.
>
> Okay I have rolled the changes you made to PatternFormatter into main
> PatternFormatter so hopefully you don't need ExtensiblePatternFormatter
> anymore.
Kewl (notice : I learn your langage ;) I'll remove them from Cocoon at
the next LogKit release.
>
> I also include rolled functionality of getting class on stack into
> StackIntrospector. So you should be able to go
>
> StackIntrospector.getCallerClass( Logger.class )
>
> and it *should* work ;)
>
> If you could make sure I didn't stuff up anything that would be kewl ;)
Things you don't have included from ExtensiblePatternFormatter but are
necessary :
- the constant MAX_TYPE (or give it another name if you want) is
necessary for subclasses robustness against evolutions of this class. If
subclasses must rely on "TYPE_PRIORITY" or "8" to know at which number
to start their new types, they will be broken if you add
"TYPE_KEWL_PATTERN = 9" !
- PatternRun is protected, which is good because it should only be used
by PatternFormatter and its subclasses. But PatterRun members must be
public, otherwise PatternFormatter subclasses won't be able to access
them.
What's the purpose of getExtension() ? It's never called in the code.
>
> Cheers,
>
> Pete
>
> *-----------------------------------------------------*
> | "Faced with the choice between changing one's mind, |
> | and proving that there is no need to do so - almost |
> | everyone gets busy on the proof." |
> | - John Kenneth Galbraith |
> *-----------------------------------------------------*
>
Thanks for putting this in Avalon.
--
Sylvain Wallez
Anyware Technologies - http://www.anyware-tech.com
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
