Peter Donald wrote:
> On Sat, 16 Mar 2002 21:10, Leif Mortenson wrote:
>
>>Most of the problems were being caused by tools.dir not being correct. It
>>looks like Ant is setting it to ../jakarta-avalon/tools when run from the
>>jakarta-avalon-excalibur directory. The problem is that that is not
>>correct relative to the build file in jakarta-avalon-excalibur/all for
>>example.
>>
>
> Thats wierd. The top level build file doesn't set the property and none of
> the other projects call any other project and thus they shouldn't "share" the
> same alues. My guess is that you were using the build.[sh|bat] file and that
> was setting the tools.dir property and this was getting passed onto child
> builds and causing havok.
Yup, I said that in response your post about my changes to the new build.xml
files and the addition of the build scripts. When I built with a standard Ant,
things all worked fine.
>> > > Got the tests all running, but there are several failing tests in the
>> > > extensions, i18n, and naming sub-projects. cli and io both pass.
>> >
>> > Wierd. All of them passed out of the box previously in my setup. Can you
>> > describe what was failing?
>>
>>I'll attach the failing test results. They fail both when running build
>>dist from the root and when running build test within each sub project
>>directory.
>
> Man am I stupid!
I know the feeling this weekend :-)
> I was assuming that because the build passed the tests were passing. However
> junit will by default continue building even if unit tests fail ... so my
> mistake.
>
> A few of these things needed code changes but most of the problems were the
> fact that I had not set up build.xml files to copy all required resources and
> or allowed abtract classes to be tested.
>
> I just fixed this - can you rerun this and check that it works for you ?
They all pass now.
What do you think of having a task in the root build file which would, after
running all of the tests, use junitreport to build one giant report of all of
the test results from all of the subprojects. That way they could all be
viewed in one place. It is not always desirable to have the build fail when
a test does not pass, but dividing things into subprojects made it a little
more difficult to view the test results as a whole. (All in all it was a
smart move though.)
...
It was easy so I went ahead and made the change. Let me know your thoughts.
To make this work, the subprojects' test-reports task can not delete the xml
test results. I just commented them out for now, if we want to stick with
this change, I'll go ahead and delete them.
It would also be nice to do something similar for the javadocs of all of the
subprojects. It is really nice to be able to have them all together.
Cheers,
Leif
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
