Hi Pete,

        Thanks for your feedback.
        
> On Sun, 14 Apr 2002 21:49, Marcus Crafter wrote:
> > Hi All,
> >
> > I've written a new logkit target for review, which logs events
> > via email. The new target is attached, as SMTPOutputTarget.
> > It requires the javamail jar file available from
> > http://java.sun.com/products/javamail/index.html.
> >
> > If you have any comments, etc, feel free to fire away. If
> > there's no major problems and it's ok with everyone, I'll check
> > the source file into logkit later on during the week.
> 
> Looks good. The only thing I would change is move the SMTP session
> creation out of the constructor so that it is easier to integrate into existing 
> systems that already have a session available to themand preconfiured
> (like many j2ee servers).

        Good idea. I will update the constructor to work with a preconfigured
        session object.

        Cheers,
        
        Marcus
        
--      
        .....
     ,,$$$$$$$$$,      Marcus Crafter
    ;$'      '$$$$:    Computer Systems Engineer
    $:         $$$$:   ManageSoft GmbH
     $       o_)$$$:   82-84 Mainzer Landstrasse
     ;$,    _/\ &&:'   60327 Frankfurt Germany
       '     /( &&&
           \_&&&&'
          &&&&.
    &&&&&&&:

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to