Yes - you are absolutely correct about running the test case first. As we
have problems here with people not running test cases (if they exist!), I
should know better. Your gentle reminder is taken. :)
So I ran org.apache.log.output.test.RevolvingFileStrategyTestCase which I
think is the one you created. Quite instructive looking at the code.
Unfortunately one test "testFullRotationWithYounger" failed so then I had a
closer look at the tests and the versioning of the test cases. Of course I
had the version 1.1 whereas the latest is 1.2. Hence the gentle reminder to
run the test cases?
Thanks for the applying the patches all the same.
Peter Donald <[EMAIL PROTECTED]> on 18/04/2002 19:23:55
Please respond to "Avalon Developers List" <[EMAIL PROTECTED]>
To: "Avalon Developers List" <[EMAIL PROTECTED]>
cc:
Subject: Re: Logkit: RevolvingFileStrategy - suggested changes.
Applied - thanks. BTW you probably should have run the test case before
submitting a patch :)
--
Cheers,
Peter Donald
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]
>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]
>
****************************************************************
NOTICE - This message is intended only for the use of the
addressee named above and may contain privileged and
confidential information. If you are not the intended recipient
of this message you are hereby notified that you must not
disseminate, copy or take any action based upon it. If you
received this message in error please notify HIC immediately.
Any views expressed in this message are those of the individual
sender, except where the sender specifically states them to be
the views of HIC.
****************************************************************
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
