donaldp     2002/07/11 18:24:09

  Modified:    src/java/org/apache/avalon/cornerstone/blocks/connection
                        Connection.java
  Log:
  Simplify message debugging
  
  Revision  Changes    Path
  1.15      +20 -15    
jakarta-avalon-cornerstone/src/java/org/apache/avalon/cornerstone/blocks/connection/Connection.java
  
  Index: Connection.java
  ===================================================================
  RCS file: 
/home/cvs/jakarta-avalon-cornerstone/src/java/org/apache/avalon/cornerstone/blocks/connection/Connection.java,v
  retrieving revision 1.14
  retrieving revision 1.15
  diff -u -r1.14 -r1.15
  --- Connection.java   12 Jul 2002 01:21:33 -0000      1.14
  +++ Connection.java   12 Jul 2002 01:24:09 -0000      1.15
  @@ -163,25 +163,12 @@
               m_thread = Thread.currentThread();
               m_runners.add( this );
   
  -            if( getLogger().isDebugEnabled() )
  -            {
  -                final String message =
  -                    "Starting connection on " +
  -                    m_socket.getInetAddress().getHostAddress();
  -                getLogger().debug( message );
  -            }
  +            debugBanner( true );
   
               handler = m_handlerFactory.createConnectionHandler();
               handler.handleConnection( m_socket );
   
  -            if( getLogger().isDebugEnabled() )
  -            {
  -                final String message =
  -                    "Ending connection on " +
  -                    m_socket.getInetAddress().getHostAddress();
  -                getLogger().debug( message );
  -            }
  -
  +            debugBanner( false );
           }
           catch( final Exception e )
           {
  @@ -204,6 +191,24 @@
   
                   notifyAll();
               }
  +        }
  +    }
  +
  +    /**
  +     * Print out debug banner indicating that handling of a connection
  +     * is starting or ending.
  +     *
  +     * @param starting true if starting, false othrewise
  +     */
  +    private void debugBanner( final boolean starting )
  +    {
  +        if( getLogger().isDebugEnabled() )
  +        {
  +            final String prefix = ( starting ) ? "Starting" : "Ending";
  +            final String message =
  +                prefix + " connection on " +
  +                m_socket.getInetAddress().getHostAddress();
  +            getLogger().debug( message );
           }
       }
   
  
  
  

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to