On Tue, 1 Oct 2002, Berin Loritsch wrote: > Giacomo Pati wrote: > > On Tue, 1 Oct 2002, Peter Royal wrote: > > > > > >>On Tuesday, October 1, 2002, at 02:55 PM, [EMAIL PROTECTED] wrote: > >> > >> > >>>giacomo 2002/10/01 11:55:59 > >>> > >>> Modified: > >>>fortress/src/java/org/apache/excalibur/fortress/container/commands > >>> CheckTypeInfoCommand.java > >>> DisposeComponentHandlerCommand.java > >>> InitializeComponentHandlerCommand.java > >>> Log: > >>> get rid of global and unused imports (hope this is ok ;-) > >> > >>It is very ok :) > > > > > > Well, I've seen there are plenty of location with global imports in the > > fortress package. Is this intentional? Should I go for removing them? > > In many places we pretty much use the entire package. It is simpler/ > shorter just to import the whole package. In most cases it is only done > with Framework classes.
Siplicity is not allways the best way for people to study code. Excplicit imports clearly state which class belongs to which package. After having a look into the org.apache.excalibur.fortress.container.MetaDataContainer class I simply got lost (ok, I know Avalon quite well and know where those classes come from or I'm good at guessing). Once the common consens was that global imports should be banned. Do you guys have changed this policy? Giacomo -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
