On Mon, 11 Nov 2002 20:32, Leo Sutic wrote: > > From: Peter Donald [mailto:peter@;apache.org] > > > > ex-C++ developers > > *Quiet! Don't tell anyone!* > > > The one place where this convention was broken (NIO) ended up > > being regretted by the EG members who pushed through the change. > > I'm not familiar with this. Do you have a link?
The problems with synchronization and resource management are well known. Neither are problems for C++ as most of those methods are inlined and there is no synchornized keyword and thus the user has to explicitly manage synchronization anyways. Should be able to find with a websearch. Regarding EG members there is no lin as it occured under NDA> It just happens that one of the JCP groups I am involved/observe has many of the same members as nio and requires heavy interaction with them. > Is it related to subclassing (i.e. subtype can not override > return type, even to subtype of supertype's return type)? Thats not usually the problem. > I would prefer to keep the code as-is. The code you're changing > is three months old and thus released with Fortress 1.0, irrespective > of the technical merits of one solution over another. > > http://cvs.apache.org/viewcvs.cgi/jakarta-avalon-excalibur/fortress/src/ > java/org/apache/excalibur/fortress/util/ContextBuilder.java.diff?r1=1.21 > &r2=1.22&diff_format=h > > If the issues surrounding the idiom is serious enough I have no problem > fixing it (I can do the proper deprecation cycle). What is your estimate > - > is it serious enough to warrant deprecation, renaming of methods (as > you can not overload on return type)? It doesn't negatively impact any of our stuff because nothing in our work is resource management or synchronized. However it does break standard design patterns of java (ie java beans) which is bad enough IMHO. Either way I have left it in and cloned a beanized version ForrestConfig. ContextBuilder delegates to ForrestConfig so you can continue to use that if you want without any fear of backwards compatability breaks. If you ever feel like retracting your veto feel free to remove ContextBuilder ;) -- Cheers, Peter Donald ------------------------------------------------ "No. Try not. Do. Or do not. There is no try." -- Yoda ------------------------------------------------ -- To unsubscribe, e-mail: <mailto:avalon-dev-unsubscribe@;jakarta.apache.org> For additional commands, e-mail: <mailto:avalon-dev-help@;jakarta.apache.org>
