Re: cvs commit: jakarta-avalon-excalibur/sourceresolve/src/java/org/apache/excalibur/source/implSourceResolverImpl.java

[Stephen McConnell]

Berin Loritsch wrote:

From: Carsten Ziegeler [mailto:[EMAIL PROTECTED]]

The contract is (or should explicitly be) this:

* Composable can return ComponentSelector or Component
* Serviceable can return ServiceSelector or service (as an Object)

No Serviceable should ever return a ComponentSelector,
and vice versa.

Ok, I understand this - but what currently happens (in Cocoon) is,
we have for many components a ComponentSelector.

Now, you have a Serviceable component, looking up the selector.
And this is then a ComponentSelector and not a ServiceSelector. It's
not automatically transformed.

I wanted to change from ComponentSelector to ServiceSelector, but
failed, because I didn't found any usable implementation of a ServiceSelector. Is there any?

:)

If memory serves me correctly, Peter D. backported my wrappers to
turn a ComponentSelector into a ServiceSelector and a
ComponentManager that into a ServiceManager.  The wrapper will
catch any instance of a ServiceSelector and automagically wrap it
with the other.

I've been using this recently - issues came up when running James and problems occured when using the wrapper classes. Don't remember exactly but I had to put in place a Component proxy to solve the issue of components in Cornerstone that were implementing Block (i.e. Component) - and when Block was removed they become imcompatible with ComponentManager and ComponentSelector. Putting the proxy into the wrapper package would be needed to complete the story - hawever - I don't see the need for this content to be in framework proper. Its something that could easily be packaged as a utility jar.

My solution was to copy the wrapper classes from framework to avalon-sandbox/assembly, add the necessary extras, and move on from there.

http://cvs.apache.org/viewcvs.cgi/avalon-sandbox/assembly/src/java/org/apache/avalon/assembly/locator/

They should be in Framework 4.1.3--but need to double-check.

Framework 4.1.3 is the replacement to the 4.12 that was incorerectly packaged. It contains the service package additios to the framework. It does not container the wrapper classes.

Cheers, Steve.

--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

--

Stephen J. McConnell
mailto:[EMAIL PROTECTED]
http://www.osm.net




--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>