On Thu, Oct 04, 2001 at 03:31:33PM +0200, Arpi wrote:
> Hi,
> > (avm::string is basicaly char* - except we do not have to call free)
> > (guess why default.h contains this line: //#define std avm )
>
> Hey man, why do you need free() there at all?
> The caller program (aviplay/mplayer) pass a char* pointer to DSHow decoder
> constructor in order to open the codec. The _caller_ must worry about
> free()ing its string, not the dll loader / directshow interface lib!!!
well I've created for you very limited CodecInfo structure
in avifile its used for more then just opening dll and
CodecInfo structure might be copyied - we could declare that dll name
would have to be a pointer to some memory which will never be freeed
- but I guess it's easier to use avm::string - so CodecInfo will have
it's own copy and when it will be destroyed it will free this pointer
- in C you would have to call strdup and free - C++ will hide this.
> > I've thought I'll receive patch
> I think it's simpler for you check diff between mplayer and avifile tree,
> and update avifile if needed. Of course I can generate the patch for you if
> you can't/don't want...
hmm but will take some time.
> > I think they are used - except in very unusual conditions - but ACM
> > audio driver is definitely using them.
> Hmm, really. acmStreamOpen is called from outside, and it goes to driver.c
> How do you handle the codec DLL filename then? Are you using the hardcodec
> names in driver.c ? It's very bad then...
as I said - it's broken - I know that - but currently it's not that much
important and will be fixed during the cleanup of memory leaks in this code.
I guess we should finaly decide that we will maintain this part of avifile
no matter what wine project will produce and in that case we should
probably cleanup most parts of this code - I've been comparing new wine source
and they seems to be completely incompatible so we may probably forget
about updating this code and rather fixup and cleanup current one
(there are bigger problems then hardcoded dll names :))
--
.''`. Which fundamental human right do you want to give up today?
: :' : Debian GNU/Linux maintainer - www.debian.{org,cz}
`. `' Zdenek Kabelac kabi@{debian.org, users.sf.net, fi.muni.cz}
`- Resistance is futile. You all will be packaged
_______________________________________________
Avifile mailing list
[EMAIL PROTECTED]
http://prak.org/mailman/listinfo/avifile
