On 1/15/19 1:20 PM, Plamen Dimitrov wrote:
> Hi all,
>
> I am new to the avocado-vt repo and it seems that merging pull requests
> there has a different workflow than pull requests in avocado. In
> particular, it seems that no review is required for a merge - am I
> correct to assume this? I have 5-6 pull requests waiting and after
> waiting for some time I just realized that GitHub is giving me green
> light for each pull request without blocking. Shouldn't a main
> maintainer also look at the code or is it good to go if it passes all
> unit tests?
>
Avocado-VT workflow requires two ACKs, but you're right that the GH UI
is not preventing merges.
Xu, Lukáš (and others),
Would you like to activate the merge block feature on GH?
Thanks,
- Cleber.
> Best,
> Plamen
>
--
Cleber Rosa
[ Sr Software Engineer - Virtualization Team - Red Hat ]
[ Avocado Test Framework - avocado-framework.github.io ]
[ 7ABB 96EB 8B46 B94D 5E0F E9BB 657E 8D33 A5F2 09F3 ]
