+1 from me. Chunfu Wen
----- Original Message ----- From: "Cleber Rosa" <cr...@redhat.com> To: "Dan Zheng" <dzh...@redhat.com> Cc: avocado-devel@redhat.com, "Lukas Doktor" <ldok...@redhat.com>, "Kyla Zhang" <weiz...@redhat.com>, "Chunfu Wen" <ch...@redhat.com>, "Xu Han" <xu...@redhat.com>, "Satheesh Rajendran" <sathn...@linux.vnet.ibm.com>, "Balamuruhan S" <bal...@linux.ibm.com>, "mzhan" <mz...@redhat.com> Sent: Thursday, October 8, 2020 10:55:01 PM Subject: Re: [Avocado-devel] Suggestion for a new avocado-vt maintainer On Thu, Oct 08, 2020 at 12:28:39PM +0800, Dan Zheng wrote: > Hello maintainers, > > I am glad to recommend Chloerh (github ID) as avocado-vt maintainer. > I proposed to grant her as both avocado-vt and tp-libvit maintainers three > months ago and finally we decided to grant her as a tp-libvirt maintainer > first. > Now regarding the situation that we have more and more PRs' contributions > and high reviewing workload as well as her good performance/improvements, > I think it is time to post this proposal again instead of waiting for more > months. So* I am appreciated for your feedback.* > > haizhao has been tp-libvirt maintainer since July 2020. > During the past 3 months, she not only contributed much to tp-libvirt, but > also more efforts in avocado-vt. > > What she has done: > 1. 386 contributions were done since 2020 and 180 of them were done in the > past 3 months. > 2. 13 avocato-vt PRs were submitted, and 50+ avocado-vt PRs were reviewed > since 2020. 46% contributions were for code reviewing. > 3. She is pre-actively testing the latest avocado branch integration with > avocado-vt(tp-libvirt) locally. > 4. She is strict to code quality and actively provides better > implementation. > > I have seen other improvements from her, like: > 1. Her wording attitude in review comments is becoming more and more nice. > 2. She is more able to think from the position of the whole team in some > discussions. > > BTW, below is some positive feedback from feature owners within the > libvirt QE team. > > From: Jianan Gao <j...@redhat.com> > Date: Tue, Sep 29, 2020 at 5:02 PM > +1 > Haijiao is the teacher of my auto work, I super agree with her as a > maintainer, she is my idol !!! > > Jgao > On Tue, Sep 29, 2020 at 4:47 PM Yingshun Cui <yi...@redhat.com> wrote: > > > +1 > > I totally agree with you. She always gives me a quick feedback on > > reviewing PRs. > > > > > > On Tue, Sep 29, 2020 at 4:33 PM Yalan Zhang <yalzh...@redhat.com> wrote: > > > >> > >> Hi dzheng, > >> > >> I can't agree more with the sentence below: > >> She is strict to code quality and actively provides better implementation. > >> She is more able to think from the position of the whole team in some > >> discussions. > >> > >> And she is very careful to review the code and give me many suggestions, > >> and she even explains it to me with google meet. > >> She is very responsible with the open PR and reminds me several times. I > >> agree with the recognition and promotion. > >> > >> ------- > >> Best Regards, > >> Yalan Zhang > >> IRC: yalzhang > >> > >> > >> On Tue, Sep 29, 2020 at 4:25 PM Dan Zheng <dzh...@redhat.com> wrote: > >> > >>> Hi maintainers & feature owners, > >>> > >>> This email is to ask for your feedback for promoting haizhao(github ID: > >>> Chloerh) to become an avocado-vt maintainer. > >>> I *appreciate* your replies. > >>> > >>> ... > >>> > >> > > > > -- > > > > Regards, > Dan Zheng (dzh...@redhat.com) > Libvirt, Virtualization > Redhat Beijing R&D Hi Dan, I've seen a lot of (good) traffic from Chloerh, so +1 from me. Let me know if I can help with anything else (permissions on the repo?). Thanks, - Cleber.