+1 On Thu, Sep 16, 2021 at 8:27 AM Lucas Meneghel Rodrigues <look...@gmail.com> wrote:
> You guys made a good case for YingShun. I'm onboard. > > I am on a couple of days of vacation, so if Cleber or Lukas can grant > maintainership before I have access to a computer that'll be great. > Otherwise I'll do it ASAP. > > Thanks! > > On Wed, Sep 15, 2021, 5:01 AM Luyao Huang <lhu...@redhat.com> wrote: > >> +1 >> >> In my opinion, YingShun is good enough to be a maintainer since she >> already contributed a lot of commits to the upstream tp-libvirt project and >> avocado-vt project. >> >> BR, >> Luyao >> >> On Tue, Sep 14, 2021 at 12:27 PM Dan Zheng <dzh...@redhat.com> wrote: >> >>> Hello all, >>> I'd like to advocate for YingShun https://github.com/YingShun to become >>> an avocado-vt/tp-libvirt maintainer. >>> >>> She has total 483 >>> <https://github.com/Yingshun?tab=overview&from=2021-01-01&to=2021-09-14> >>> contributions till now in 2021 and 568 contributions in 2020, 233 >>> contributions in 2019 on avocado-vt/tp-libvirt projects. >>> >>> She is *No.1* contributor with 174 commits >>> <https://github.com/autotest/tp-libvirt/graphs/contributors?from=2020-01-01&to=2021-09-14&type=c> >>> 6,537 ++ for tp-libvirt and *No.2* contributor with 94 commits >>> <https://github.com/avocado-framework/avocado-vt/graphs/contributors?from=2020-01-01&to=2021-09-14&type=c> >>> 2,208 ++ for avocado-vt since 2020. >>> >>> She is the main contributor on automating several libvirt features' >>> cases. The features involve migration(auto owner), SRIOV(auto owner), cpu, >>> libvirt-guest and so on. She also fixed issues for some features, like >>> blockcommit, blockpull, remote_access and etc. She is the main contributor >>> to implement the support for libvirt modular daemon solution in avocado-vt. >>> Till now, she has submitted 234 >>> <https://github.com/autotest/tp-libvirt/pulls?q=is%3Apr+author%3AYingshun> >>> tp-libvirt PRs (232 merged) and 124 >>> <https://github.com/avocado-framework/avocado-vt/pulls/YingShun> >>> avocado-vt PRs( 124 merged). In addition, she has also participated in the >>> PR review actively and carefully for 198 >>> <https://github.com/avocado-framework/avocado-vt/pulls?q=is%3Aopen+is%3Apr+reviewed-by%3AYingShun+> >>> avocado-vt PRs and 374 >>> <https://github.com/autotest/tp-libvirt/pulls?q=is%3Aopen+is%3Apr+reviewed-by%3AYingshun+> >>> tp-libvirt PRs in the past 3 years. >>> >>> Welcome your feedback. >>> >>> Regards, >>> Dan Zheng (dzh...@redhat.com) >>> Libvirt, Virtualization >>> Redhat Beijing R&D >>> >>
