[ 
https://issues.apache.org/jira/browse/AVRO-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12767587#action_12767587
 ] 

Doug Cutting commented on AVRO-152:
-----------------------------------

Some comments on the patch:
  - You added a "never returns null" to Schema#getName().  This is not relevant 
to this issue, and it's not true.  The record schema used to represent a 
message's parameter list is anonymous.
 - You've also made style changes (e.g., adding braces) in code unrelated to 
this issue.  Can you please remove these?
 - Do you intend the addition of new parameters to public Schema methods to be 
an incompatible change?  I'm okay with this, but it must be called out, so that 
we're sure to list it as an incompatible change in the next release.
 - The refactoring of SpecificCompiler does not seem required by this issue.  
It does perhaps simplify TestSpecificCompiler, but that also could be written 
to instead operate on files.  In either case, I would prefer this were 
addressed in a separate issue.

> Adding "doc" to record schemas, a la javadoc field and class comments.
> ----------------------------------------------------------------------
>
>                 Key: AVRO-152
>                 URL: https://issues.apache.org/jira/browse/AVRO-152
>             Project: Avro
>          Issue Type: New Feature
>            Reporter: Philip Zeyliger
>            Assignee: Philip Zeyliger
>         Attachments: AVRO-149.patch.txt, AVRO-152.patch.txt
>
>
> The patch to follow adds "doc" to the understood schema language (for records 
> and enums), and uses said doc when it generates java in SpecificCompiler.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to