[ 
https://issues.apache.org/jira/browse/AVRO-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768071#action_12768071
 ] 

Philip Zeyliger commented on AVRO-149:
--------------------------------------

Back from travels; clearing out the queue!

bq. You renamed the script, but you did not rename the various comments that 
still use the term "avrotool". These should all be changed to "avroj", no?

Yep, fixed.  The package is still org.apache.avro.tool, which I prefer over 
"avroj", but if you have a strong preference, the search and replace would be 
trivial.

bq. Most other projects commonly use the bin/ directory for executable scripts, 
and do not have two copies in releases.

I've moved the script into bin/avroj.  I've removed the VERSION substitution.  

bq. The warnings generated by the script will be annoying to developers like 
me, who will use these scripts a lot. 

Removed the warning.

bq. avroj vs. avroj.sh

It's "avroj" now.  The test script still has a ".sh" suffix on it, since it's 
really in the src/ tree.


BTW, are you aware of anything that auto-generates stubs like "avroj"?  It 
seems like every Java project in the world has to have one of these.  
Inevitably, we'll be adding things similar to $HADOOP_CLASSPATH to this script 
soon.  I'd use a canned script if I knew of one that was liked.

The diff is also updated to fix some trivial merge conflicts in build.xml.

> "avrotool" runner to execute avro commands from command-line
> ------------------------------------------------------------
>
>                 Key: AVRO-149
>                 URL: https://issues.apache.org/jira/browse/AVRO-149
>             Project: Avro
>          Issue Type: New Feature
>            Reporter: Philip Zeyliger
>            Assignee: Philip Zeyliger
>         Attachments: AVRO-149.patch.txt, AVRO-149.patch.txt, 
> AVRO-149.patch.v2.txt
>
>
> There's already an ant task to generate java code based on a schema, but you 
> can't do it from the command-line, with any ease.  I will shortly upload a 
> patch that does just that.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to