[ 
https://issues.apache.org/jira/browse/AVRO-163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Massie updated AVRO-163:
-----------------------------

    Attachment: AVRO-163.patch

Submitted a revised patch to build.xml which:

1. Changes "package" target to just do a raw copy of the 'src/c' from 
subversion. No C binaries.
2. Adds a new "tar-c" convenience target for generate a C package artifact 

bq. I don't see the point of putting the autotools package into the 
"monolithic" tar ball.

That was because of my misunderstanding the voting process.  I thought that in 
order to release a C package artifact it would need to be packaged in the 
release we vote on.  Now I understand that the vote is on a particular 
subversion tag basically.  I've completed removed the autotools package and now 
the 'src/c' directory is just copied verbatim from subversion.


bq. I thought the plan was to:

I completely agree with this plan and the updated patch moves us closer toward 
this goal.

However, I *didn't* (for now):
* Change the primary tarball name to avro-src.
* Changed packaging for any other language but C
* Change how documentation is being generated

bq. If you only want to do the C-related parts of this now, that's probably 
fine, and we can file issues to do the others before we next release. But 
packaging the autotools package into the primary tarball seems like a step in 
the wrong direction.

Agreed.  See above.  

bq. I can't tell whether there's something you don't like about my proposal, or 
something you don't get about it. 

I can promise without qualification that if I don't like a proposal, I will 
publicly state so.  I misunderstood the requirements and process.

bq. ...and I don't see a compelling reason to try to invent new Apache policy. 
http://www.apache.org/dev/release.html

I wasn't trying to invent new policies and thank you for helping me learn more 
about the release process at Apache.  I'm sorry for any frustration my initial 
ignorance caused.

bq. Then please make that a part of the target run by 'ant test' at the 
top-level, if you have not already. That target is intended for folks who'd 
like to try to test everything fully.

I did that in the original and subsequent patch updates.

I've also add a convenience 'tar-c' target for building a release.  If you want 
to generate the C side artifacts at the same time as the primary tarball, you 
can simply run

$ ant tar tar-c

The build directory will then have the primary tarball with signatures *and* 
the C side artifacts with signatures.

Doug, I hope that you and rest of the Avro team have a good weekend.



> Each language Avro supports should be a separate package
> --------------------------------------------------------
>
>                 Key: AVRO-163
>                 URL: https://issues.apache.org/jira/browse/AVRO-163
>             Project: Avro
>          Issue Type: Improvement
>          Components: c, c++, java, python
>    Affects Versions: 1.0.0, 1.1.0, 1.2.0
>         Environment: We currently release Avro as a single monolithic tarball 
> with ant being used to build all the languages that Avro supports.
>            Reporter: Matt Massie
>            Assignee: Matt Massie
>            Priority: Critical
>             Fix For: 1.2.1, 1.3.0
>
>         Attachments: AVRO-163.patch, AVRO-163.patch
>
>   Original Estimate: 8h
>  Remaining Estimate: 8h
>
> *Build Issue*
> While ant is used for building Java projects, it is almost never used to 
> build python, c++ or c projects.  C and C++ projects are often managed using 
> autotools while Python uses setuptools.  Forcing these languages to use a 
> foreign build system ('ant') is suboptimal and will cause us headaches as we 
> move forward.
> *Release issue*
> Releasing a single monolithic package forces users of one language to 
> download binary and source for all languages.  For example, at this time the 
> Avro C distribution is only 384K in size (built using autotools 'make 
> distcheck' target).  People interested in using the C implementation would be 
> forced to download a large monolithic tarball (currently 3.8 MB) that 
> includes dozens of third-party jar files for the Java implementation.  
> Furthermore, C users would be forced to use 'ant' as the top-level build 
> tool.  This monolithic approach would also prevent us from submitting Avro 
> for inclusion in Linux distribution yum/apt repositories as RPM and Debian 
> packages.  It's important to allow C/C++ code to have a pristine release 
> tarball on which to base Debian and RPM packaging.
> *Solution*
> Create top-level directories: 'java', 'python', 'c++ ' , 'c', 'shared' and 
> 'release'.  Each language directory would contain the source for that 
> language and use the build system natural for that language, e.g. ant, 
> autotools, setuptools, gem, etc.  The 'shared' directory would have, for 
> example, common test schema and data files for interoperability testing 
> between each language.  A simple top-level bash script would call into each 
> language to build a release package, documentation, etc. into the 'release' 
> directory.  Each Avro release would then be compromised of package(s) for 
> each language Avro supports, e.g. avro-java-1.2.3.tar.gz, 
> pyavro-1.2.3.tar.gz, avro-c++-1.2.3.tar.gz and avro-c-1.2.3.tar.gz.  Later 
> on, we'll also likely have libavro-devel-1.2.3-1.x86_64.rpm too.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to