[
https://issues.apache.org/jira/browse/AVRO-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770080#action_12770080
]
Philip Zeyliger commented on AVRO-161:
--------------------------------------
Seems reasonable from far away, though I'm not currently very familiar with the
python code.
You should add pydoc to __init__, create_new, and create_for_append, since it's
not clear which one one is supposed to use. You should move the "from
avro.genericio import DatumReader" up to the top of the file. In
create_for_append and create_enw, the existence of the kwargs variable seems
unnecessary; you might just do:
{noformat}
return cls(writer, dwriter, schema=schema.parse(...),
sync=...,
codec=...,
...
)
{noformat}
Besides that, though, everything seems reasonable.
> Add test to Python bindings for opening a non-empty file object container and
> successfully adding new elements
> --------------------------------------------------------------------------------------------------------------
>
> Key: AVRO-161
> URL: https://issues.apache.org/jira/browse/AVRO-161
> Project: Avro
> Issue Type: Test
> Reporter: Jeff Hammerbacher
> Attachments: AVRO-161.patch
>
>
> Avro file object container are mutable and we should test that fact.
> testio.py currently just tests open a file for writing, writing a few
> records, closing the file, then reading the file back in.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
