[ 
https://issues.apache.org/jira/browse/AVRO-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776682#action_12776682
 ] 

Philip Zeyliger commented on AVRO-192:
--------------------------------------

Took a look at the patch.  +1.

It'd be nice if the tests asserted that a certain string was in the error 
message, but I don't insist.  That's just gravy.

bq. throw new RuntimeException("Should not have parsed: "+json);

I think you could just do fail("Should have not parsed:" + json), which causes 
junit to record this as an assertion failure instead of an exception, though 
I've never much bothered with caring which way tests failed.

> schema parser needs better error handling for arrays and maps
> -------------------------------------------------------------
>
>                 Key: AVRO-192
>                 URL: https://issues.apache.org/jira/browse/AVRO-192
>             Project: Avro
>          Issue Type: Improvement
>          Components: java
>            Reporter: Doug Cutting
>            Assignee: Doug Cutting
>            Priority: Minor
>             Fix For: 1.3.0
>
>         Attachments: AVRO-192.patch, AVRO-192.patch
>
>
> Java's schema parser fails with a NullPointerException if an array schema 
> lacks an "items" type specification or a map schema lacks a "values" type 
> specification.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to