[ 
https://issues.apache.org/jira/browse/AVRO-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12780160#action_12780160
 ] 

Patrick Hunt commented on AVRO-202:
-----------------------------------

Re "Added 'datafile' to module list in both (see AVRO-201)"

I saw that but assumed that datafile is an internal detail that you typically 
don't want to expose through import *, no?

Re "heroic work" 

all in a days work for a commiter - as Doug often reminds me that's the primary 
responsibility of a commiter. ;-)

As I mentioned (doug correct me if I'm wrong, but this is the way ZK works), I 
think you'll find reviews come quicker if you "submit" the JIRA once you are 
satisfied with your patch. earlier reviews are fine too, but submission raises 
the issue on the radar since the JIRA will show up on the "patch available" 
list.

Good work, nice to see you contributing changes, python WTF!

> Add __all__ listing to avro module
> ----------------------------------
>
>                 Key: AVRO-202
>                 URL: https://issues.apache.org/jira/browse/AVRO-202
>             Project: Avro
>          Issue Type: Improvement
>          Components: python
>            Reporter: Jeff Hammerbacher
>            Assignee: Jeff Hammerbacher
>            Priority: Minor
>         Attachments: AVRO-202.patch, AVRO-202.patch, AVRO-202.patch, 
> AVRO-202.patch
>
>
> Folks who want to say "from avro import *" will need this listing: 
> http://docs.python.org/tutorial/modules.html#importing-from-a-package.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to