[ 
https://issues.apache.org/jira/browse/AVRO-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784458#action_12784458
 ] 

Doug Cutting commented on AVRO-245:
-----------------------------------

Since there's no code in the containing class, I see no point to having it.  
Rather we should just have JsonToBinaryTool and BinaryToJsonTool.

Also, these should be more symmetric, both either taking their input from a 
file, from the command line or from standard input.  My preference would 
probably be either a named file or standard in/out if that's not provided.

You're not using the container file format, but rather just a file containing a 
single record.  A tool that takes json lines from standard input and emits an 
avro data file and vice versa would be useful, no?

Finally, it doesn't look like you close the file you open for write.

> Commandline utility for converting to and from Avro's binary format.
> --------------------------------------------------------------------
>
>                 Key: AVRO-245
>                 URL: https://issues.apache.org/jira/browse/AVRO-245
>             Project: Avro
>          Issue Type: New Feature
>          Components: java
>            Reporter: Philip Zeyliger
>            Assignee: Philip Zeyliger
>            Priority: Minor
>         Attachments: AVRO-245.patch.txt
>
>
> A utility for avrotool that can convert between Avro binary data and the JSON 
> textual form.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to