[
https://issues.apache.org/jira/browse/AVRO-242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Doug Cutting updated AVRO-242:
------------------------------
Attachment: AVRO-242.patch
> I think the code would be simpler (fewer null checks, equalProps & propsHash
> wouldn't be necessary) if you didn't mind creating an extra HashMap per
> Schema.
Yeah, I guess so. I was not worried about the size of schema instances, but
rather about the speed of parsing and constructing schemas. This patch already
affects that a lot, since primitive schemas are no longer constants, and I'd
hoped not make it worse yet by constructing a HashMap for each primitive in a
schema. But, as you argued elsewhere, in cases where this is a cost (e.g., per
file block) we can usually probably arrange to cache schema instances.
I've changed this in the attached patch.
> Do you dislike the Java 1.5 for syntax?
It's not applicable here. The iterator() method enumerates values, but we want
keys. JsonNode has no keySet() or entrySet() method.
> There's sometimes not going to be a text value. Is there a test for that?
I added one.
> add support for per-schema metadata
> -----------------------------------
>
> Key: AVRO-242
> URL: https://issues.apache.org/jira/browse/AVRO-242
> Project: Avro
> Issue Type: New Feature
> Components: java
> Reporter: Doug Cutting
> Assignee: Doug Cutting
> Fix For: 1.3.0
>
> Attachments: AVRO-242.patch, AVRO-242.patch
>
>
> The Avro specification permits schema json to contain other property names to
> be used besides those listed in the specification. I propose adding support
> to Java for getting and setting these.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
