[ https://issues.apache.org/jira/browse/AVRO-327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thiruvalluvan M. G. updated AVRO-327: ------------------------------------- Attachment: AVRO-327-2.patch I worked on Doug's patch and fixed most of the problems. But TestCompare and TestDataFile still fail. TestCompare fails because, I think, BinaryData class assumes that the decoder will not read past the required bytes. TestDataFile fails because we are not able to sync to the next sync point since that is already been read into the BufferedBinaryDecoder's buffer. I think we'll also lose out on the ByteBufferInputStream optimization. In our eagerness to read more data than absolutely necessary, we'll end up having part data in the BufferedDecoder's buffer and the rest in ByteBufferInputStream killing latter's optimization. > Performance improvements to BinaryDecoder.readLong() > ---------------------------------------------------- > > Key: AVRO-327 > URL: https://issues.apache.org/jira/browse/AVRO-327 > Project: Avro > Issue Type: Improvement > Components: java > Reporter: Thiruvalluvan M. G. > Assignee: Thiruvalluvan M. G. > Attachments: AVRO-327-2.patch, AVRO-327.patch > > > AVRO-315 proposed performance improvements to readLong(), readFloat() and > readDouble(). readLong() did not improve performance well for all. Scott > proposed a better method (but requires a change in semantics and API). We'll > carry on the discussion on that proposal here. AVRO-315 will be committed > with changes for readFloat() and readDouble(). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.