[
https://issues.apache.org/jira/browse/AVRO-383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12806036#action_12806036
]
Doug Cutting commented on AVRO-383:
-----------------------------------
I'm +0 with the logic duplication in the patch: it's unfortunate, since we'll
have to update two places if either (a) this logic has common bugs, or (b) the
spec changes. I suspect (a) is more likely than (b). But, Thiru, you've
provided some reasons why sharing this logic might not be easy and I don't see
an easy alternative.
> There is a proposal to implement GenericDatumReader using ResolvingDecoder.
Do we yet have a Jira for this?
> Optiminzing ResolvingDecoder for default values
> -----------------------------------------------
>
> Key: AVRO-383
> URL: https://issues.apache.org/jira/browse/AVRO-383
> Project: Avro
> Issue Type: Improvement
> Components: java
> Reporter: Thiruvalluvan M. G.
> Assignee: Thiruvalluvan M. G.
> Attachments: AVRO-383-test.patch, AVRO-383.patch
>
>
> When the reader's and writer's schemas are records and the reader's schema
> has a field with default value and the writer's schema doesn't have the
> field, the ResolvingDecoder keeps the default value in a byte array. This
> byte array is in Json format. Moving this to Avro binary format improves
> performance.
> Apply the test patch and try "Perf -M". Then apply the patch and run it
> again. On my machine, the performance is three times the original.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.