[ 
https://issues.apache.org/jira/browse/AVRO-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Doug Cutting updated AVRO-321:
------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

I just committed this.

> Perhaps change HttpServer to use Server.setGracefulShutdown(2000 /* 2 
> seconds); in stop()?

I'd rather not make stop() always delay.  We only need the delay here, I think, 
when we're stopping from within a response.

> could you add a "description" attribute to the target named 
> "interop-data-generate" so that it shows up when running ant -p?

Done.

> should we test different codecs in interop, and should we do more than just 
> assert non-null? That is, should we try to validate values?

Good stuff for later.  Let's walk before we run.  We should test codecs.  We 
should validate.

> I did not implement interop-data-generate--I didn't see the point of having 
> that implemented in more than one language, particularly if we check in the 
> raw data itself.

I don't follow.  How do we otherwise know that a Java program can read a file 
written by Python?

> Can you also set the svn properties on the 
> share/test/interop/bin/test_rpc_interop.sh to be executable?

That was already done.  The problem is that the patch program ignores this.

> Run Java RPC interop tests again
> --------------------------------
>
>                 Key: AVRO-321
>                 URL: https://issues.apache.org/jira/browse/AVRO-321
>             Project: Avro
>          Issue Type: Test
>          Components: build, java
>            Reporter: Jeff Hammerbacher
>            Assignee: Doug Cutting
>             Fix For: 1.3.0
>
>         Attachments: AVRO-321.patch, AVRO-321.patch, AVRO-321.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to