[
https://issues.apache.org/jira/browse/AVRO-261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thiruvalluvan M. G. updated AVRO-261:
-------------------------------------
Attachment: AVRO-261.patch
Good catch. I failed to override remove(int) method. The latest patch fixes
that.
bq. If there are serious objections to depending on another jar (and I get
that), let's just lift Google's ImmutableList implementation (it's
apache-licensed).
I'm not so much against Google's jar. But I'm reluctant to add a jar just for
this single purpose. [Though this patch is large, the changes due to
LockableArrayList is quite small. The rest are cleaning up of the Schema's
public interface. I think the new interface is better irrespective of
LockableArrayList.]
bq. Also, this patch breaks GenAvro. GenAvro.java is generated by JavaCC, so if
you changed that locally, the change didn't get propagated.
I did update GenAvro.jj. By any chance your build didn't Javacc?
> Allow Schemas to be immutable
> -----------------------------
>
> Key: AVRO-261
> URL: https://issues.apache.org/jira/browse/AVRO-261
> Project: Avro
> Issue Type: New Feature
> Components: java
> Reporter: Kevin Oliver
> Assignee: Thiruvalluvan M. G.
> Priority: Minor
> Attachments: AVRO-261.patch, AVRO-261.patch, AVRO-261.patch
>
>
> It would be nice if there was the ability to have an immutable Schema in
> java.
> Without this, it makes sharing schemas risky. Also, with this, we could
> (lazily) cache the hashCode which is a fairly expensive operation today,
> especially on something like a record.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
