At 1234374118 time_t, Gregor Best wrote:
> This time everything should be alright.

It is almost!
One thing I changed:

> +    if(c->isurgent != urgent)
> +    {
> +        c->isurgent = urgent;
> +        ewmh_client_update_hints(c);
> +        /* update ICCCM hints */
> +        xcb_wm_hints_t wmh;
> +        xcb_get_wm_hints_reply(globalconf.connection,
> +                              
> xcb_get_wm_hints_unchecked(globalconf.connection, c->win),
> +                              &wmh, NULL);

You're doing synchronous request, you suck like Xlib.
I've changed to:

    if(c->isurgent != urgent) 
    {    
        xcb_get_property_cookie_t hints = 
            xcb_get_wm_hints_unchecked(globalconf.connection, c->win); 
 
        c->isurgent = urgent; 
        ewmh_client_update_hints(c); 
 
        /* update ICCCM hints */ 
        xcb_wm_hints_t wmh; 
        xcb_get_wm_hints_reply(globalconf.connection, hints, &wmh, NULL); 
 
Which is more asynchornous (we do thing while we're waiting for the
reply).

Otherwise, good, so pushed. ;)

Cheers,
-- 
Julien Danjou
// ᐰ <jul...@danjou.info>   http://julien.danjou.info
// 9A0D 5FD9 EB42 22F6 8974  C95C A462 B51E C2FE E5CD

Attachment: signature.asc
Description: Digital signature

Reply via email to