-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Julien Danjou wrote:
> At 1244292328 time_t, Uli Schlachter wrote:
>> I'm just a human.... Attached is a New and Improved (tm) version of this
>> first
>> patch.
>
> Me too, ignore my previous mail.
>
>> ---
>> lib/awful/wibox.lua.in | 11 +++++++++--
>> wibox.c | 4 ++--
>> 2 files changed, 11 insertions(+), 4 deletions(-)
>>
>> diff --git a/lib/awful/wibox.lua.in b/lib/awful/wibox.lua.in
>> index 190caea..939f52e 100644
>> --- a/lib/awful/wibox.lua.in
>> +++ b/lib/awful/wibox.lua.in
>> @@ -237,14 +237,21 @@ function new(arg)
>> -- Empty position and align in arg so we are passing deprecation warning
>> arg.position = nil
>>
>> + -- Set default size
>> + if position == "left" or position == "right" then
>> + arg.width = arg.width or capi.awesome.font_height * 1.5
>> + arg.height = arg.height or 100
>> + else
>> + arg.width = arg.width or 100
>> + arg.height = arg.height or capi.awesome.font_height * 1.5
>> + end
>> +
>> local w = capi.wibox(arg)
>>
>> if position == "left" then
>> w.orientation = "north"
>> - w:geometry({ width = capi.awesome.font_height * 1.5 })
>> elseif position == "right" then
>> w.orientation = "south"
>> - w:geometry({ width = capi.awesome.font_height * 1.5 })
>> end
>>
>> w.screen = arg.screen or 1
>
> Now I understand this patch. Ok.
>
>> diff --git a/wibox.c b/wibox.c
>> index 69009c9..a54634c 100644
>> --- a/wibox.c
>> +++ b/wibox.c
>> @@ -488,8 +488,8 @@ luaA_wibox_new(lua_State *L)
>> w->sw.border.width = luaA_getopt_number(L, 2, "border_width", 0);
>> w->sw.geometry.x = luaA_getopt_number(L, 2, "x", 0);
>> w->sw.geometry.y = luaA_getopt_number(L, 2, "y", 0);
>> - w->sw.geometry.width = luaA_getopt_number(L, 2, "width", 100);
>> - w->sw.geometry.height = luaA_getopt_number(L, 2, "height",
>> globalconf.font->height * 1.5);
>> + w->sw.geometry.width = luaA_getopt_number(L, 2, "width", 0);
>> + w->sw.geometry.height = luaA_getopt_number(L, 2, "height", 0);
>
> Is that really needed? Because 0 is invalid, so it seems bad to set this
> by default.
Hm, dunno. Just skip that part of the patch, fine with me.. (yeah, you are
right, as always)
- --
"Do you know that books smell like nutmeg or some spice from a foreign land?"
-- Faber in Fahrenheit 451
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iQEcBAEBCAAGBQJKKrnkAAoJECLkKOvLj8sGQ+oH/RvmdOt7o9BirK0R3XnwG6Ua
weCjVX4aNObHAY5G01x3gheoZKI4dv9l/DU71C1skYJvCwfSjHYbE+wZg/k/vj6k
XLZFvjYS0t8mAd5/uO8k9NvloGWodsRH1s77SsPvt+ZJ7kE4xyW7eOIyjah2rSew
hfrOBaWZnuvGKTjfnB6AEpGVkMzfPIhETaPjjjTk6wlViJEB9veSnGj/O0g3lK4B
RoeLyZ7kj2T/lC2/TuOoqSyPNbyzNpXFqC0xcaOx4GH9DHRX34cKawRtBOmwlCeb
WdQCEBG+hq4EVtBP88ZuxzDUshj8lOr+rmZDU4/d0L2Q0vyunLDjhUOmWy2/V50=
=e/d+
-----END PGP SIGNATURE-----
--
To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.
