On 26.02.2012 05:56, Anurag Priyam wrote: > On Tue, Feb 21, 2012 at 10:45 PM, Anurag Priyam > <anurag08pri...@gmail.com> wrote: >> On Tue, Feb 21, 2012 at 10:33 PM, Daniel Silverstone >> <dsilv...@digital-scurf.org> wrote: > [...] >>> local keygrabber = (args.keygrabber == nil) and true or args.keygrabber >>> >>> That might work better for you >> >> Thanks Daniel. >> >> I will resend it tomorrow. Need to study for tomorrow's exam now. > > Sorry people. I was caught up with exams and post exams partying around :). > > Here is the correct patch, tested on both values (keygrabber = > true/false) this time. But before this patch is applied, we should > perhaps consider removing keygrabber support from menu instead.
So should I merge this or not? Sending a patch with the words "but before this patch is applied" feels wrong (but has it's uses...). > Optionally allowing keygrabbers adds to the complexity of the code. > And for what gains? Without keygrabber enabled, you can't even close > the menu by pressing 'Escape' key (this is what prompted me to change > the default to true). I guess I wouldn't mind. If it simplifies the code a lot, I'm all settled for this. However, I don't really have the time to look closely into this. Anyone out there who opens up a popup menu, then clicks somewhere else and expects the menu to stay open? If yes, speak up now or stay quiet forever! Uli -- - Buck, when, exactly, did you lose your mind? - Three months ago. I woke up one morning married to a pineapple. An ugly pineapple... But I loved her. -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.
