I use spawn_with_shell to control mpd by making keyboard shortcuts for mpc
commands in rc.lua. Just using spawn makes the mouse cursor change to it's
loading state. Is there any way to work around this or does using bash -c stop
this from happening(I'm not at my computer at the moment so I can't test it)?
This is my first time replying to a mailing list, so I hope I did everything
right.
On 1. apr. 2012, at 22:00, Uli Schlachter <psyc...@znc.in> wrote:
> On 31.03.2012 13:40, Anurag Priyam wrote:
>> Fixed a bug.
>
> I diff'd the two patches. I wouldn't quite call that "a bug", but ok. :-P
>
>> +---
>> +-- <p>Switch to a client matching the given condition if running, else
>> spawn it.
>
> This tag is never closed?
>
>> +-- If multiple clients match the given condition then the next one is
>> focussed.
>> +--
>> +-- @param cmd the command to execute
>> +-- @param matcher a function that returns true to indicate a matching client
>> +-- @param merge if true then merge tags when clients are not visible
>> +--
>> +-- @usage run or raise urxvt (perhaps, with tabs) on modkey + semicolon
>> +-- <p><code>
>
> Neither does this '<p>' ever get the joy of being matched by a kind and
> friendly
> '</p>'.
>
>> +-- awful.key({ modkey, }, 'semicolon', function () <br/>
>> +-- local cmd = 'urxvt' <br/>
>
> I don't really care, but does this need a local var? Can't it just be given
> inline in the argument to run_or_raise()?
>
>> +-- local matcher = function (c) <br/>
>> +-- return awful.rules.match(c, {class = 'URxvt'}) <br/>
>> +-- end <br/>
>> +-- awful.client.run_or_raise(cmd, matcher)
>> +-- end);
>> +-- </code>
>> +function run_or_raise(cmd, matcher, merge)
>> + local clients = capi.client.get(s)
>
> This 's' is falling out of thin air? Didn't you mean to have that as an
> argument
> to this function? (Or just always as nil?)
>
>> + local findex = util.table.hasitem(clients, capi.client.focus) or 1
>> + local start = util.cycle(#clients, findex + 1)
>> +
>> + for c in cycle(matcher, start) do
>
> If you use 's' above to calculate the index, you should pass in 's' here, too.
> Also, I didn't know we had such a function, nice find.
>
>> + jumpto(c, merge)
>> + return
>> + end
>> +
>> + -- client not found, spawn it
>> + util.spawn(cmd)
>
> I wonder if this should be turned into a callback instead? Well, at first I
> was
> thinking about someone needing spawn_with_shell, then I thought about that.
>
> Hm, on second thought (actually, third) I don't think that 'spawn_with_shell'
> thingie is a valid use case and if someone asks for it, he will get told to
> use
> bash -c.
>
>> +end
>
> Uli
> --
> "In the beginning the Universe was created. This has made a lot of
> people very angry and has been widely regarded as a bad move."
>
> --
> To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.
--
To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.
