THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY. The following task has a new comment added:
FS#1037 - some enhancements to screen focus changing functions User who did this - Abdó Roig (abdo) ----------
Why is ignoring enter/leave a good idea (the old code didn't do that either)?
I bypass the mouse:enter / leave because when I change screen I want to focus the last focused client on that screen, not the client under the cursor. If one works back and forth between two screens, I think this is almost the universally desired behaviour. The old code didn't need this, because moved the cursor away, so no wrong focusing issues.
Why would everyone want the cursor position to stay relatively the same?
Fair enough. It annoyed me that moving to the secondary screen and coming back changed the cursor position. It did not occur to me one could would use it as you do. I can add the extra argument, if you insist on it. However it seems cleaner to me to just keep functions focused with one task. screen.focus() should change screen and nothing more. Then we may add screen.pointer_away() to just move the cursor out of the way. What do you like best?
The second patch duplicates too much code from awful.client, IMHO. Can we somehow have this in just a single place?
Yup. I'll send new patches as soon as I have the time ---------- More information can be found at the following URL: https://awesome.naquadah.org/bugs/index.php?do=details&task_id=1037#comment3184 You are receiving this message because you have requested it from the Flyspray bugtracking system. If you did not expect this message or don't want to receive mails in future, you can change your notification settings at the URL shown above. -- To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.
