THIS IS AN AUTOMATED MESSAGE, DO NOT REPLY.

The following task is now closed:

FS#1225 - SEGFAULT in spawn() (git-master)
User who did this - Uli Schlachter (psychon)

Reason for closing: Fixed
Additional comments about closing: commit 
800a9a41f6b705612ebe1d42246e05b77fbd281d
Author: Uli Schlachter <psyc...@znc.in>
Date:   Wed Mar 12 11:10:48 2014 +0100

    spawn: Don't try to spawn with empty argv (FS#1225)
    
    When e.g. calling awesome.spawn({}), our argv array would be empty, so just 
a
    pointer to a NULL pointer that marks the end of the array.
    
    Since startup notification was enabled, this would then try to figure out 
the
    name of the started binary. This would immediately dereference a NULL 
pointer
    and crash.
    
    Signed-off-by: Uli Schlachter <psyc...@znc.in>

commit 5432e0a332c61abcfee8c08efab07ebf793f29c7
Author: Uli Schlachter <psyc...@znc.in>
Date:   Wed Mar 12 11:12:23 2014 +0100

    awesome.spawn(): Check table arguments better
    
    Previously, any not-string-convertible entry in the array argument would 
result
    in lua_tostring() returning NULL which g_strdup() would pass through. Thus, 
we
    would end up with a NULL entry in an array whose end is marked with a NULL
    entry. This mainly means that we had a memory leak.
    
    Fix this by actually verifying that we only have strings in the table that 
we
    are looking at.
    
    Signed-off-by: Uli Schlachter <psyc...@znc.in>

commit f9a1093e45bb249a6c6a988c497248bf3051b6b3
Author: Uli Schlachter <psyc...@znc.in>
Date:   Wed Mar 12 11:15:40 2014 +0100

    spawn: Remove useless argv[0] calculation
    
    Since commit 3c40d6b, the passed in argument is decomposed into an array of
    strings before the sn-related code runs. This means we already know argv[0] 
and
    thus we don't need the code here that tries to figure it out again.
    
    Signed-off-by: Uli Schlachter <psyc...@znc.in>


More information can be found at the following URL:
https://awesome.naquadah.org/bugs/index.php?do=details&task_id=1225

You are receiving this message because you have requested it from the Flyspray 
bugtracking system.  If you did not expect this message or don't want to 
receive mails in future, you can change your notification settings at the URL 
shown above.

--
To unsubscribe, send mail to awesome-devel-unsubscr...@naquadah.org.

Reply via email to