On 02/10/12 03:58 AM, Michael Barker wrote:
Hi Stuart,
Thank you for the reviewing the patches. I forgot about the
Contributed-by header, sorry about that. That's one I'll put on the
list to make sure I have sorted next time. I've split the
contributors up according to the two patches supplied. See below:
AWT, beans& printing:
To close the loop on this, I pushed the AWT/bean/print changes to the
jdk8/awt/tl repo.
http://mail.openjdk.java.net/pipermail/awt-dev/2012-February/002252.html
It looks like Stuart will take care of the ones going through jdk8/tl/jdk.
-Chris.
Contributed-by: Prasannaa<prasannaa...@yahoo.com>, Martijn Verburg
<martijnverb...@gmail.com>, Goerge Albrecht<goerge.albre...@gmx.net>,
Graham Allan<grundlefl...@googlemail.com>, Iordanis Giannakakis
<i.giannaka...@ymail.com>, Jose Llarena<jose.llar...@gmail.com>,
Abraham Marín Pérez<abraham.marin.pe...@gmail.com>
For all of the remaining code:
Contributed-by: Mani Sarkar<sadhak...@gmail.com>, Michael Barker
<mike...@gmail.com>, Carl Jokl<carl.j...@gmail.com>, Dinuk
Weerasinghe<dinu...@yahoo.com>, Markus Stoy
<markus.s...@timgroup.com>, Tom Anderson<tom.ander...@timgroup.com>
I hope these patches are providing value for the OpenJDK team as we
plan to do more. I know that there is a bit of a cost for you guys
in terms of reviewing and merging. I'm starting to get a better
picture of the type of changes that will go in smoothly and those that
will require updates to the patches.
Mike.
On Fri, Feb 10, 2012 at 3:11 AM, Stuart Marks<stuart.ma...@oracle.com> wrote:
Hi Mike,
I finally got back to this. These fixes look pretty good and knock off 100+
additional warnings! I've filed bug 7143230 [1] to track this. I took a look
through the code and I took the liberty of fixing up a few very minor
things:
1. Removed unnecessary casts to ZipEntry in JarVerifier.java, suggested by
Chirs Hegarty [2]. (These aren't strictly redundant casts, and don't cause
warnings, as the origin types are<? extends ZipEntry> and JarEntry.
However, they are unnecessary.)
2. Fixed typo in unrelated comment at line 50 in SignatureFile.java that I
happened to notice.
3. Removed parentheses from expressions in MemoryMonitor.java lines 216, 219
which are now unnecessary since the cast has been removed.
No need to issue another patch; I'll just include these changes when I push
the changeset.
Which brings me to the topic that we discussed before when I pushed LJC's
previous round of warnings fixes, that is, how the Contributed-by line in
the commit message should be formatted. (See [3] for the requirements.) For
reference, here's what the changeset comment for the previous set of LJC
fixes ended up looking like:
changeset: 4802:4f0f9f9c4892
user: smarks
date: Wed Dec 07 12:12:50 2011 -0800
description:
7117249: fix warnings in java.util.jar, .logging, .prefs, .zip
Reviewed-by: alanb, dholmes, forax, sherman, smarks
Contributed-by: Prasannaa<prasannaa...@yahoo.com>, Martijn Verburg
<martijnverb...@gmail.com>, Goerge_Albrecht<goerge.albre...@gmx.net>,
Graham Allan<grundlefl...@googlemail.com>, Michael Barker
<mike...@gmail.com>
It looks like a different set of people contributed to this round of fixes.
If you could send me the list of names and email addresses, I can format
them into the commit message and push the fix.
Thanks!
s'marks
[1] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7143230
[2]
http://mail.openjdk.java.net/pipermail/jdk8-dev/2012-February/000715.html
[3] http://openjdk.java.net/guide/producingChangeset.html
On 2/4/12 12:12 AM, Chris Hegarty wrote:
Thanks for this, looks great.
Good to see JarVerifier getting some much needed TLC.
-Chris.
On 02/ 4/12 07:50 AM, Michael Barker wrote:
I see Rémi has suggested a slice& dice but I think that's a bit too much
work for the changes involved. Instead I would suggest a simple split,
send
the AWT/Printing/Beans changes to awt-dev + 2d-dev, and everything else
to
core-libs-dev.
Attached is the patch that contains "everthing else" from LJC warning
fixes hack session.
Mike.
