Thanks for the confirmation. The fix looks fine to me then.

--
best regards,
Anthony

On 5/25/2012 3:04 PM, Alexander Zuev wrote:
Anthony, I have checked it on Windows and Ubuntu - seems like there's no 
regressions caused by this fix.

With best regards,
Alexander Zuev

25.05.2012, в 14:38, Anthony Petrov <[email protected]> написал(а):

Hi Alexander,

I guess I'm a bit late with the review, but my comment also concerns the fix 
for 7u6. You're changing the shared file SunDropTargetContextPeer.java and 
reverting a boolean argument when calling postDropTargetEvent. Can this change 
affect other platforms? Have you run some tests for DnD area on Win and X11 to 
verify nothing is broken?

--
best regards,
Anthony

On 5/24/2012 1:36 PM, Alexander Zuev wrote:
Hello,
 please review my fix for the
7171163: [macosx] Shortcomings in the design of the secondary native event loop 
made JavaFX DnD deadlock
 Bug can be found at http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7171163
 Webrev can be found at:
http://cr.openjdk.java.net/~kizune/7171163/webrev.01/
With best regards,
Alexander Zuev

Reply via email to