Oleg,
This looks OK to me but since this is a shared code change I have
to ask what testing you've done ?
Also why not provide a regression test ? The provided test was
interactive but I think it can be automated.
You need another review and I'd like Jim to take a look.
-phil.
On 8/10/2012 2:26 PM, Oleg Pekhovskiy wrote:
Hi,
Please review the fix for CR:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7153339
Webrev:
http://cr.openjdk.java.net/~bagiras/8/7153339.1/
Comments:
XOR is not supported for D3D (see comments inside
D3DSurfaceData.validatePipe()) and
software rendering is used invalidating current D3DSurfaceData.
So we have situation when component's peer has invalid SurfaceData and
it's retrieved in
SunGraphics2D.revalidateAll() through SurfaceData.getReplacement()
without any check.
That's why I added validity check there.
Thanks,
Oleg
<http://cr.openjdk.java.net/%7Ebagiras/8/7153339.1/>
